Skip to content

Support Lenovo laptop with rt722 and rt1320#5695

Open
oortcomet wants to merge 3 commits intothesofproject:topic/sof-devfrom
oortcomet:lnv-rt722-rt1320-1
Open

Support Lenovo laptop with rt722 and rt1320#5695
oortcomet wants to merge 3 commits intothesofproject:topic/sof-devfrom
oortcomet:lnv-rt722-rt1320-1

Conversation

@oortcomet
Copy link

These commits support the combination with rt722 and rt1320 soundwire devices.

  • rt722 in Link3 -> UAJ
  • rt1320 in Link2 -> AMP & MIC

Mac Chiang and others added 3 commits March 12, 2026 10:43
…bles

Use functional topologies to support RT722 topologies with/without amplifiers,
e.g. sof-ptl-rt722.tplg, sof-ptl-rt722-rt1320.tplg...

If these entries are not removed, they will find the first same link of
sof-ptl-rt722.tplg.

Signed-off-by: Mac Chiang <mac.chiang@intel.com>
According to the Intel sof design, it will create the name prefix
appended with amp index for the amp codec only, such as:
rt1318-1, rt1318-2, etc...

But the rt1320 is a codec with amp and mic codec functions, it doesn't
have the amp index in its name prefix as above.
And then it will be hard to identify the codec if in multi-rt1320 case.
So we add a flag to force the amp index to be appended.

Signed-off-by: Derek Fang <derek.fang@realtek.com>
Add 'rt1320-aif2' dai info for rt1320 dmic function.

Signed-off-by: Derek Fang <derek.fang@realtek.com>
@sofci
Copy link
Collaborator

sofci commented Mar 13, 2026

Can one of the admins verify this patch?

reply test this please to run this test once

@bardliao
Copy link
Collaborator

test this please

@bardliao
Copy link
Collaborator

@oortcomet Please remove rt_mf_endpoints[] in the first commit.

sound/soc/intel/common/soc-acpi-intel-ptl-match.c:141:43: error: unused variable 'rt_mf_endpoints' [-Werror,-Wunused-const-variable]
  141 | static const struct snd_soc_acpi_endpoint rt_mf_endpoints[] = {
      |                                           ^~~~~~~~~~~~~~~
1 error generated.

Also, please add your "Co-developed-by" and "Signed-off-by" tags to the first commit. Like

Signed-off-by: Mac Chiang mac.chiang@intel.com
Co-developed-by: Derek Fang derek.fang@realtek.com
Signed-off-by: Derek Fang derek.fang@realtek.com

@bardliao
Copy link
Collaborator

And please fix the check patch warning.

Commit 4eb16a50aae5 ("ASoC: sdw_utils: add rt1320 dmic dai in codec_info_list")
-------------------------------------------------------------------------------
WARNING: line length of 104 exceeds 100 columns
#41: FILE: sound/soc/sdw_utils/soc_sdw_rt_dmic.c:35:
+	 * If there is any rt1320 DMIC belonging to this card, try to count the `cfg-mics` to be used in

WARNING: line length of 107 exceeds 100 columns
#47: FILE: sound/soc/sdw_utils/soc_sdw_rt_dmic.c:41:
+		mic_name = devm_kasprintf(card->dev, GFP_KERNEL, "%s", codec_info->dais[i].component_name);

WARNING: line length of 113 exceeds 100 columns
#55: FILE: sound/soc/sdw_utils/soc_sdw_rt_dmic.c:49:
+				if (sdw_peripheral->sdca_data.function[i].type == SDCA_FUNCTION_TYPE_SMART_MIC) {

CHECK: Unbalanced braces around else statement
#61: FILE: sound/soc/sdw_utils/soc_sdw_rt_dmic.c:55:
+	} else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants